Fix sliced_string_as_bytes FP with a RangeFull
#15873
Open
+17
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
sliced_string_as_bytes]: don't fire onstr[..].as_bytes()So I ran into this in some codebase I was working on,
where the lint fired on this line:
So I was trying to understand the rationale behind this lint, and it says:
This is obviously not true in the case where a
RangeFullslice is being taken, since there is no UTF-8 boundary check, and no panic can be caused. So I created an exemption forRangeFulls.Two other notes:
str[..].len()orslice[..].len(), wherestrandsliceare&strand&[T], respectively. If we had one, I would expect it to fire for the example code I quoted above.